Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LiveChatTextMessage): Make some fields optional #877

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonz94
Copy link
Contributor

@jonz94 jonz94 commented Jan 19, 2025

  • Mark menu_endpoint property as optional
  • Mark context_menu_accessibility_label property as optional

Example RawNode data:

{
  "liveChatTextMessageRenderer": {
    "message": {
      "runs": [
        {
          "text": "!"
        }
      ]
    },
    "authorName": {
      "simpleText": "庫洛姆•Kuromu"
    },
    "authorPhoto": {
      "thumbnails": [
        {
          "url": "https://yt4.ggpht.com/vKALKrLFo09MqpQASaS1hvOBVN9FRMn4aUPxf8UU8OzQCMXT8-C-XilHREtyV-wCeGwFee8_0A=s32-c-k-c0x00ffffff-no-rj",
          "width": 32,
          "height": 32
        },
        {
          "url": "https://yt4.ggpht.com/vKALKrLFo09MqpQASaS1hvOBVN9FRMn4aUPxf8UU8OzQCMXT8-C-XilHREtyV-wCeGwFee8_0A=s64-c-k-c0x00ffffff-no-rj",
          "width": 64,
          "height": 64
        }
      ]
    },
    "id": "ChwKGkNJX0M4dHFSOVlvREZUelN3Z1FkRjlVaWZB",
    "timestampUsec": "1736855168796805",
    "authorBadges": [
      {
        "liveChatAuthorBadgeRenderer": {
          "icon": {
            "iconType": "OWNER"
          },
          "tooltip": "Owner",
          "accessibility": {
            "accessibilityData": {
              "label": "Owner"
            }
          }
        }
      }
    ],
    "authorExternalChannelId": "UC2ZWggon1NOT2TGaVUMzY7A",
    "trackingParams": "CAYQl98BIhMIsP-Rz6aBiwMVe2r1BR3LvzM3"
  }
}

- Mark `menu_endpoint` property as optional
- Mark `context_menu_accessibility_label` property as optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant