fix(user-display): handle null string in isNotEmptyString (#3136) (#…

…3148) Co-authored-by: Flavien Normand <[email protected]>
LuccaSA · Oct 21, 2024 · da52a33 · da52a33
1 parent 1f7fe2d
commit da52a33
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/packages/ng/option/selector/all/select-all.component.ts b/packages/ng/option/selector/all/select-all.component.ts
@@ -40,6 +40,9 @@ export class LuOptionSelectAllComponent<T> extends ALuOptionOperator<T> implemen
 	public intl = getIntl(LU_OPTION_SELECT_ALL_TRANSLATIONS);
 
 	selectAll() {
+		if (!this.options) {
+			return;
+		}
 		this.onSelectValue.next([...this.options]);
 	}
 	deselectAll() {

diff --git a/packages/ng/option/selector/all/tree-select-all.component.ts b/packages/ng/option/selector/all/tree-select-all.component.ts
@@ -40,6 +40,9 @@ export class LuTreeOptionSelectAllComponent<T> extends ALuTreeOptionOperator<T>
 	public intl = getIntl(LU_OPTION_SELECT_ALL_TRANSLATIONS);
 
 	selectAll() {
+		if (!this.flatOptions) {
+			return;
+		}
 		this.onSelectValue.next([...this.flatOptions]);
 	}
 	deselectAll() {

diff --git a/packages/ng/user/display/user-display.pipe.ts b/packages/ng/user/display/user-display.pipe.ts
@@ -6,7 +6,7 @@ function getFirstCharacter([firstCharacter]: string): string {
 }
 
 function isNotEmptyString(value: string): boolean {
-	return value.length > 0;
+	return value?.length > 0;
 }
 
 export interface LuUserDisplayInput {
@@ -51,7 +51,12 @@ export function luUsersDisplay(users: LuUserDisplayInput[], options: LuUserDispl
 
 export type LuUserDisplaySingleOptions = LuDisplayFormat | { format: LuDisplayFormat };
 
-export type LuUserDisplayMultipleOptions = { format: LuDisplayFormat; separator: string } | { format: LuDisplayFormat; formatter: Intl.ListFormat };
+export type LuUserDisplayMultipleOptions =
+	| { format: LuDisplayFormat; separator: string }
+	| {
+			format: LuDisplayFormat;
+			formatter: Intl.ListFormat;
+	  };
 
 /**
  * Displays a user name according to specified format. Supported formats: f for first name,