-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WIFISerialCommunication #106
base: main
Are you sure you want to change the base?
Conversation
changed ECHO to ECHO_WIRELESS_DATA
changed COMMUNICATION to default to COMM_SERIAL
refactored code
reverted proto5 changes in file to match main
Fixed and tested, should work now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good to me, thank you. Lucas will probably also need to do a pass before merging it, and I can find some time to work on adding WiFi to the driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small thing and then i think this will be ready to merge
removed newline
removed debug
removed debug
This is done right? The newlines have been removed as requested. Once this is merged we'll have wireless support for the faemod, so it's kind of a big deal. |
Not entirely, you still need the Server to work, which needs some polishing. Adding this directly to the opengloves-driver shouldn't be too difficult and would remove the need for the virtual com ports, but I lack the time to do so. If you want to use the wifi support with the fae mod today you can create 2 linked com ports with com0com and use my Reroute Server |
needs tcp server to work
https://github.com/REXXER301/TCP-COM-Reroute.git
Emulates a serialPort connection to trick the opengloves driver into thinking it is directly connected via cable