Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quotation marks in f-string #60

Closed
wants to merge 1 commit into from

Conversation

dolph
Copy link

@dolph dolph commented Apr 22, 2024

Closes: #59

@ConnorTroy
Copy link
Contributor

It appears that there are several other f-strings with the same issue: main...ConnorTroy:mkdocs-drawio-exporter:f-string-quotes

@mriedem
Copy link

mriedem commented Apr 23, 2024

Thanks for posting this. @LukeCarrier have you thought about running flake8 or some other static code check during CI runs?

@LukeCarrier
Copy link
Owner

LukeCarrier commented Apr 23, 2024

Hey, thanks for fixing this. I'm happy to review any CI and release improvements but have barely enough time to maintain this as is.

In this case having a wider test matrix covering older Python versions prior to 3.12 would have caught this, and that's a quick win here (#61).

@LukeCarrier
Copy link
Owner

Have taken @ConnorTroy's linked diff above and added a missing __future__ annotation for the typings introduced in 0.9.0, both in #62. #61 should ensure I don't break everyone again in the next release :-)

@LukeCarrier LukeCarrier added this to the v0.9.1 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError: f-string: unmatched '[' with 0.9.0 release
4 participants