Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #14: Conditionally execute npm install if npx is being used. #15

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Issue #14: Conditionally execute npm install if npx is being used. #15

merged 2 commits into from
Jul 26, 2024

Conversation

elvism-lullabot
Copy link
Collaborator

No description provided.

@elvism-lullabot
Copy link
Collaborator Author

wondering what will happen if the project does not have any JS package manager

@deviantintegral
Copy link
Member

wondering what will happen if the project does not have any JS package manager

Is this possible though? Pretty much every project will at least have sass or postcss?

deviantintegral
deviantintegral approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@deviantintegral deviantintegral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This works as advertised. I added one additional small fix to make sure npm ci had been called before calling npx (to match yarn above).

@deviantintegral deviantintegral merged commit 78dde07 into main Jul 26, 2024
2 checks passed
@deviantintegral deviantintegral deleted the 14--update-npx-commands-execution branch July 26, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deviantintegral deviantintegral deviantintegral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elvism-lullabot @deviantintegral