Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For dev: update with main] Issue #535: Change multidev deploy to manual only: tag based #670

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

YesCT
Copy link
Contributor

@YesCT YesCT commented Aug 28, 2024

Relates to:

Description:

  • Run the Multidev Deploy when the label pantheon-multidev is added

Next steps

  • Address feedback

References

From justafish

Here's the relevant bit of code that will need modifying https://github.com/Lullabot/drainpipe/blob/main/src/ScaffoldInstallerPlugin.php#L285

#546 (comment)


jobs:
Drainpipe-Deploy-Pantheon-Multidev:
if: contains(github.event.pull_request.labels.*.name, 'pantheon-multidev')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: contains(github.event.pull_request.labels.*.name, 'pantheon-multidev')
if: (contains(github.event.pull_request.labels.*.name, 'pantheon-multidev') && ${{ vars.PANTHEON_MULTIDEV_MANUAL }} == "true") || ${{ vars.PANTHEON_MULTIDEV_MANUAL }} != "true"

From justafish

Could we do something like that instead of duplicating the files? (haven't tested it so not sure if it'll work!)

#546 (comment)

scaffold/github/workflows/PantheonReviewAppsManual.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants