Fix index migration bug

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 1.4.4
 
 * Add another example, showing how to build repositories with a `Future<ValueListenable<T>>` interface
+* Fix index migration bug (introduced in 1.4.3), when a name is reused across index versions
 
 ## 1.4.3
 

lib/src/index_entity_store.dart

@@ -383,6 +383,11 @@ class IndexedEntityStore<T, K> {
 
       _database.execute('BEGIN');
 
+      _database.execute(
+        'DELETE FROM `index` WHERE `type` = ?',
+        [_entityKey],
+      );
+
       final entities = getAllOnce();
 
       for (final e in entities) {

test/indexed_entity_store_test.dart

@@ -135,14 +135,18 @@ void main() {
       {
         final db = IndexedEntityDabase.open(path);
 
-        final fooStore = db.entityStore(fooConnectorWithIndexOnC);
+        final fooStore = db.entityStore(fooConnectorWithIndexOnBAndC);
 
         expect(fooStore.getAllOnce(), hasLength(1));
         // old index is not longer supported
         expect(
           () => fooStore.queryOnce((cols) => cols['a'].equals('A')),
           throwsException,
         );
+        expect(
+          fooStore.queryOnce((cols) => cols['b'].equals(1002)),
+          hasLength(1),
+        );
         expect(
           fooStore.queryOnce((cols) => cols['c'].equals(true)),
           hasLength(1),
@@ -1101,11 +1105,12 @@ final fooConnector = IndexedEntityConnector<_FooEntity, int, String>(
   ),
 );
 
-final fooConnectorWithIndexOnC =
+final fooConnectorWithIndexOnBAndC =
     IndexedEntityConnector<_FooEntity, int, String>(
   entityKey: fooConnector.entityKey,
   getPrimaryKey: fooConnector.getPrimaryKey,
   getIndices: (index) {
+    index((e) => e.valueB + 1000, as: 'b'); // updated index B
     index((e) => e.valueC, as: 'c');
   },
   serialize: fooConnector.serialize,