cmake: Fix -Wno-maybe-uninitialized

Not needed now that we grab jsoncpp via known_good.json
LunarG · Aug 24, 2023 · 10e5418 · 10e5418
1 parent 51f670a
commit 10e5418
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/via/CMakeLists.txt b/via/CMakeLists.txt
@@ -13,9 +13,6 @@ else()
     if (CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")
         set(COMMON_COMPILE_FLAGS "-Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers")
         set(COMMON_COMPILE_FLAGS "${COMMON_COMPILE_FLAGS} -fno-strict-aliasing -fno-builtin-memcmp")
-        if (CMAKE_COMPILER_IS_GNUCC)
-            set(COMMON_COMPILE_FLAGS "${COMMON_COMPILE_FLAGS} -Wno-maybe-uninitialized")
-        endif()
         set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${COMMON_COMPILE_FLAGS} -fno-rtti")
     endif()
     # jsoncpp has intentional fallthrough

diff --git a/vkconfig_core/CMakeLists.txt b/vkconfig_core/CMakeLists.txt
@@ -54,12 +54,6 @@ if(Qt5_FOUND)
         target_link_libraries(vkconfig_core Cfgmgr32)
     endif()
 
-    if (CMAKE_COMPILER_IS_GNUCC)
-        # Disable -Wno-maybe-uninitialized because of warnings with jsoncpp and GCC 12
-        # TODO: Fix now that jsoncpp is grabbed via known_good.json
-        add_compile_options("-Wno-maybe-uninitialized")
-     endif()
-
     target_link_libraries(vkconfig_core Vulkan::Headers valijson vku Qt5::Core Qt5::Gui Qt5::Widgets Qt5::Network)
     target_compile_definitions(vkconfig_core PRIVATE ${VKCONFIG_DEFINITIONS})