Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

[WIP] Add initializers from ReservoirComputing #23

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MartinuzziFrancesco
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 156 lines in your changes are missing coverage. Please review.

Project coverage is 45.97%. Comparing base (ed1bddf) to head (0a0d7c1).
Report is 1 commits behind head on main.

❗ Current head 0a0d7c1 differs from pull request most recent head c107eaf. Consider uploading reports for the commit c107eaf to get more accurate results

Files Patch % Lines
src/rc_initializers.jl 0.00% 156 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #23       +/-   ##
===========================================
- Coverage   96.47%   45.97%   -50.51%     
===========================================
  Files           4        5        +1     
  Lines         142      298      +156     
===========================================
  Hits          137      137               
- Misses          5      161      +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Project.toml Outdated
@@ -5,6 +5,7 @@ version = "0.1.7"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite heavy, we should make it into an extension

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we even need that, I was using it for Uniform and now it's only needed for Bernoulli, so I'm sure we can avoid it all together. I just needed to get the tests running to catch the various CUDA errors

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants