-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Add initializers from ReservoirComputing #23
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
===========================================
- Coverage 96.47% 45.97% -50.51%
===========================================
Files 4 5 +1
Lines 142 298 +156
===========================================
Hits 137 137
- Misses 5 161 +156 ☔ View full report in Codecov by Sentry. |
Project.toml
Outdated
@@ -5,6 +5,7 @@ version = "0.1.7" | |||
|
|||
[deps] | |||
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4" | |||
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite heavy, we should make it into an extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we even need that, I was using it for Uniform
and now it's only needed for Bernoulli
, so I'm sure we can avoid it all together. I just needed to get the tests running to catch the various CUDA errors
No description provided.