Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable full support of Livewire + Tailwind: New front-end #1303

Closed
wants to merge 244 commits into from

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented May 5, 2022

WORK IN PROGRESS β€” Just ignore πŸ˜…

Setup for testing

After switching to this branch.

# Update the vendor files.
composer install 

# Update the database, there are new constants being used.
php artisan migrate 

# Set up the JS dependencies.
npm install

# Spawn the Vite server for hot reload pages on changes (recommended for development).
npm run dev
# or compile files (recommended for production).
npm run build

Then you can access the front-end at the following url:
https://yourlychee.example.org/livewire
Or by setting LIVEWIRE_ENABLED=false in your .env, in this case, the front-end will switch to Livewire completely.

Fixes

Fixes #12 β€” βœ”οΈ
Fixes #383 β€” βœ”οΈ
Fixes #725 β€” βœ”οΈ
Fixes #748 β€” βœ”οΈ (need localization)
Fixes #828 β€” βœ”οΈ
Closes #845 β€” βœ”οΈ
Fixes #857 β€” βœ”οΈ
Fixes #1053 β€” βœ”οΈ (no more public smart album)
Fixes #1211 β€” βœ”οΈ
Fixes #1249 β€” βœ”οΈ
Fixes #1189 β€” βœ”οΈ
Fixes #1253 β€” βœ”οΈ
Fixes #1462 β€” βœ”οΈ
Fixes #1676 β€” βœ”οΈ
Fixes #1704 β€” βœ”οΈ
Fixes #1720 β€” βœ”οΈ
Fixes #1732 β€” βœ”οΈ
Fixes #1891 β€” βœ”οΈ
Fixes #1948 β€” βœ”οΈ
Fixes #1973 β€” βœ”οΈ
Fixes #1989 β€” βœ”οΈ
Fixes LycheeOrg/Lychee-front#199 β€” βœ”οΈ
Fixes #2011 β€” βœ”οΈ

Fixes LycheeOrg/Lychee-front#90 β€” βœ”οΈ
Fixes LycheeOrg/Lychee-front#104 β€” βœ”οΈ
Fixes LycheeOrg/Lychee-front#166 β€” βœ”οΈ
Fixes LycheeOrg/Lychee-front#268 β€” βœ”οΈ (homebrewed css is gone)
Fixes LycheeOrg/Lychee-front#312 β€” βœ”οΈ (already fixed actually)
Fixes LycheeOrg/Lychee-front#343 β€” βœ”οΈ
Fixes LycheeOrg/Lychee-front#344 β€” βœ”οΈ
Fixes LycheeOrg/Lychee-front#373 β€” βœ”οΈ

Major breaking differences

  • Public smart album is gone.
  • Making a single pictures public is no longer an option.
  • Import from server is gone in favor of command line sync

Left menu

Done
  • : Scaffolding
  • : Actions

Setting pages

Done
  • : Scaffolding
  • : Saving/Live update
  • : Key bindings (Enter = Confirm Save all)

Log pages

Done
  • : Scaffolding
  • : Actions

Diagnostics pages

Done
  • : Scaffolding
  • : Actions

User Management pages

Done
  • : Scaffolding
  • : Actions

Profile page

Done
  • : login
  • : email
  • : U2F
    • : Scaffolding
    • : Actions
      • : rename
      • : delete
      • : add

Sharing page

Done
  • : Scaffolding
  • : Actions

Album page

Done
  • : Password request
  • : Scaffolding
  • : Navigation
  • : License
  • : Full display
    • : Justified
    • : Squared
    • : Masondry
    • : Grid
  • : Actions Albums
    • : Set visibility
    • : Set license
    • : Sharing to other users
    • : Sharing links
    • : Transfer Ownership
    • : Mark as Sensitive
    • : Download Album
    • : Move
    • : Delete
    • : Full Screen
    • : Open Side bar

Photo page

Done
  • : Scaffolding
  • : Navigation

Header

Done
  • : Scaffolding
  • : Import from Server or drop GUI functionality?
  • : Menu Albums
    • : Upload
    • : Import from Link
    • : Import from Server
    • : Create New Album
    • : Create New Tag Album
  • : Actions Photos
    • : Set Star
    • : Set license
    • : Set visibility Dropped.
    • : Rotate CW (not tested)
    • : Rotate CCW (not tested)
    • : Move
    • : Delete
    • : Full Screen
    • : Open Side bar
    • : Donwload

Sidebar

Done
  • : Scaffolding
  • : Actions Albums
  • : Actions Photos

Upload

Done
  • : Upload by chunk
  • : Limitation on parallel processing/requests

Keybinding

Done
  • : Done (mostly)

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1303 (331c5b8) into master (6b2b04c) will increase coverage by 2.72%.
The diff coverage is 93.38%.

❗ Current head 331c5b8 differs from pull request most recent head 3bffd15. Consider uploading reports for the commit 3bffd15 to get more accurate results

Additional details and impacted files

@nagmat84

This comment was marked as outdated.

@ildyria

This comment was marked as outdated.

@kamil4

This comment was marked as outdated.

@nagmat84

This comment was marked as outdated.

@ildyria

This comment was marked as outdated.

@nagmat84

This comment was marked as outdated.

nagmat84

This comment was marked as outdated.

@ildyria

This comment was marked as outdated.

app/Locale/German.php Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

app/Assets/Helpers.php Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
qwerty287

This comment was marked as off-topic.

@ildyria ildyria marked this pull request as draft August 27, 2022 12:26
@ildyria ildyria self-assigned this Oct 28, 2022
@ildyria ildyria added the Review: hard Difficult review expected: major changes, lots of files modified, and dependencies updated. label Jan 16, 2023
@ildyria ildyria changed the title Livewire/more work Enable full support of Livewire: New front-end Jan 18, 2023
@qwerty287
Copy link
Contributor

So a few points I noticed just now (maybe I'd copy this again once we have a new PR):

  1. Using the "back" button is extremely slow. It takes ~2 sec to load. Opening a new view (e.g. album) is fast though.
  2. The layout selector is also shown if there are no photos, I think it would better to hide it.
  3. Dialogs and right-click menus are still extremely slow.
  4. Navigating left/right on photos is extremely slow, it would be better to navigate directly and show a loading indicator.
  5. If you open/close the photo sidebar very often, at some point it does not work anymore and is always hidden.
  6. Opening the photo sidebar the first time moves the photo left first, then nothing happens for a short time, and then the sidebar opens. This should be synchronously.
  7. I'm not a big fan of the big buttons for photos, that gives me the feel this is software for children ;)
  8. When moving photos, the album list loads very long (it's pretty fast when moving albums though).
  9. Opening the album detail panel does not animate 100% fluently.
  10. Text inputs in dialogs have a weird border (e.g. login) Screenshot_20231003_123118

Overall it's working well (except the performance as I wrote above...), thanks for all the work!

@ildyria ildyria closed this Oct 3, 2023
@ildyria ildyria deleted the livewire/more-work branch October 3, 2023 14:33
@ildyria
Copy link
Member Author

ildyria commented Oct 3, 2023

Squashed & closed.
See #2035 for the updated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment