Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission 4 and multiple fixes #14

Merged
merged 32 commits into from
Dec 15, 2023
Merged

Mission 4 and multiple fixes #14

merged 32 commits into from
Dec 15, 2023

Conversation

LyonSyonII
Copy link
Owner

@LyonSyonII LyonSyonII commented Dec 14, 2023

Contents (#14)

New features

  • added mission 4
  • added onsuccess callback
  • added onsuccess callback
  • name is now saved to be used later
  • added "reset" button when page is in DEV mode
  • added remove function
  • Changed from Svelte Checkpoint to Astro one
  • Removed scroll when problem is completed
  • added WIP indicator to new pages

Enhancements

  • compressed AdventurersGuildGirl.svg
  • changed Checkpoint from Svelte to Astro component with vanilla JS
  • added "alt" to hero logo
  • "Progress" now loads when "indle" instead of "visible"
  • rewritten LanguageDetector component from Svelte to Astro
  • Checkpoint now displays a fade in animation when user "prefers-reduced-motion"
  • Replaced LanguageDetector for Astro one
  • [frontend/src/components/QuestionCard.astro] inlined Icons svg to allow for prefetch
  • [QuestionCard.astro] made padding smaller on mobile
  • improved SEO

Fixes

  • changed "color-mix" to "opacity" for better browser compatibility

Dependencies

  • updated dependencies

Chores

  • removed logs
  • removed logs

Style

  • removed unnecessary line
  • prettier
  • prettier
  • fixed padding and margins of QuestionCard and CodeBlock
  • removed unnecessary comment

Other

  • added comments specifying valid syntax
  • added function for guild-girl portrait
  • Writing first exercise
  • added TODO comment

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for rust-quest ready!

Name Link
🔨 Latest commit e77f4df
🔍 Latest deploy log https://app.netlify.com/sites/rust-quest/deploys/657cb51fc5c4e60008c8ee5f
😎 Deploy Preview https://deploy-preview-14--rust-quest.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 97
Best Practices: 100
SEO: 93
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@LyonSyonII LyonSyonII merged commit bb3d296 into main Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant