Rebase goreplay master

MAIF · Jan 20, 2021 · 71d8435 · 71d8435
1 parent 7b60730
commit 71d8435
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/proto/proto.go b/proto/proto.go
@@ -307,8 +307,7 @@ func Method(payload []byte) []byte {
 }
 
 // Status returns response status.
-// Status-Line = HTTP-Version SP Status-Code SP Reason-Phrase CRLF
-// Reason-Phrase is optional
+// It happens to be in same position as request payload path
 func Status(payload []byte) []byte {
 	if !HasResponseTitle(payload) {
 		return nil
@@ -352,7 +351,7 @@ func HasResponseTitle(payload []byte) bool {
 		return false
 	}
 	status, ok := atoI(payload[VersionLen+1:VersionLen+4], 10)
-	if !ok || s[VersionLen+4] != ' ' {
+	if !ok {
 		return false
 	}
 	// only validate status codes mentioned in rfc2616.

diff --git a/proto/proto_test.go b/proto/proto_test.go
@@ -136,6 +136,24 @@ func TestParseHeaders(t *testing.T) {
 	if !reflect.DeepEqual(headers, expected) {
 		t.Error("Headers do not properly parsed", headers)
 	}
+
+	// Response with Reason phrase
+	payload = [][]byte{[]byte("HTTP/1.1 200 OK\r\nContent-Length: 7\r\nHost: www.w3.org\r\nUser-Agent:Chrome\r\n\r\nbody")}
+
+	headers = ParseHeaders(bytes.Join(payload, nil))
+
+	if !reflect.DeepEqual(headers, expected) {
+		t.Error("Headers do not properly parsed", headers)
+	}
+
+	// Response without Reason phrase
+	payload = [][]byte{[]byte("HTTP/1.1 200\r\nContent-Length: 7\r\nHost: www.w3.org\r\nUser-Agent:Chrome\r\n\r\nbody")}
+
+	headers = ParseHeaders(bytes.Join(payload, nil))
+
+	if !reflect.DeepEqual(headers, expected) {
+		t.Error("Headers do not properly parsed", headers)
+	}
 }
 
 // See https://github.com/dvyukov/go-fuzz and fuzz.go