Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Fix for NumPy 2.0 Incompatibility #559

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

guillaume-vignal
Copy link
Collaborator

Temporary Fix for NumPy 2.0 Incompatibility

Description

This pull request introduces a temporary fix for the recent incompatibility issues with NumPy 2.0 by setting an upper limit on the NumPy version in setup.py.

Changes

  • Updated setup.py to restrict NumPy version to <2.0.

Rationale

NumPy 2.0 includes breaking changes that are currently incompatible with Shapash and other libraries like SHAP. By limiting the NumPy version, we prevent potential issues for users until a permanent compatibility update is available.

Additional Notes

We will continue working on making Shapash compatible with NumPy 2.0 and will remove this restriction once the necessary updates are implemented and tested.

Related Issues

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This pull request ensures that users will not unintentionally upgrade to NumPy 2.0 and encounter breaking changes. Thank you for your understanding and patience as we work on a more permanent solution.


@guillaume-vignal guillaume-vignal merged commit 32ddddf into MAIF:master Jun 24, 2024
@guillaume-vignal guillaume-vignal deleted the fix/numpy<2 branch June 24, 2024 08:49
@guillaume-vignal guillaume-vignal self-assigned this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants