-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve memory efficiency when downloading matrix data. See issue #502.
The browser can fail with an out-of-memory error when trying to download a very large data matrix (in my tests hundreds of gigabytes worth). This patch uses several strategies to increase the download size at which that happens: - Gets access windows one row at a time and only for the range of requested columns. This minimizes tile cache memory needed. - Converts rows to tsv format on the fly, so we don't need to convert the entire matrix to tsv format at once. - Constructs a blob using a vector of the row tsv data. This is more memory efficient than manually building a data URL. These steps help but don't eliminate the problem. (I don't think that's possible purely in browser.) A future patch will a display warning notice to the user for very large download sizes.
- Loading branch information
Showing
1 changed file
with
58 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters