Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend colors for scatterplot style covariates incorrect on generated pdf. #482

Open
jmelott opened this issue Apr 14, 2023 · 4 comments
Open

Comments

@jmelott
Copy link

jmelott commented Apr 14, 2023

Covariate Legends for scatterplots always displayed as red on pdf rather than colors in map
matrix_11_2000_2000_samples_samples20 (3).ngchm.zip

@bmbroom
Copy link
Member

bmbroom commented Apr 14, 2023

Actual issue is that it's displaying a numeric legend instead of a discrete legend for backgound and foreground colors.

@bmbroom
Copy link
Member

bmbroom commented Apr 14, 2023

The color is always "red" because "red" is always the last color in the color maps associated with each covariate (you can see this if you temporarily set the type back to "color_map"). Changing that last color will change the color of all boxes in that covariate's legend.

This is coded explicitly, presumably as a feature. I guess the current legend shows the distribution of values, but the color boxes are confusing.

I'm not sure what the best behavior is. We should discuss at next week's NG-CHM meeting.

@jmelott
Copy link
Author

jmelott commented Apr 20, 2023

Are you still considering this as a show-stopper?

@bmbroom
Copy link
Member

bmbroom commented Apr 20, 2023

No.

bmbroom added a commit that referenced this issue Apr 26, 2023
Previous behavior was to use the last color in the 'color_plot' color
scheme, which isn't visible in the UI unless you change the bar type
back to 'color_plot' temporarily.  It's not obvious to me that this
is (or should be) a well-defined value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants