Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGCHM Widget using deprecated JavaScript Code to set type. #526

Open
jmelott opened this issue Jan 30, 2024 · 3 comments
Open

NGCHM Widget using deprecated JavaScript Code to set type. #526

jmelott opened this issue Jan 30, 2024 · 3 comments

Comments

@jmelott
Copy link

jmelott commented Jan 30, 2024

css.type='text/css' is used in CompilerUtilities.java line 305 and NGCHM_Widgetizer.java line 127.
css.type is deprecated. The correct way to set the parameter is css.setAttribute("type", "text/css");

@bmbroom
Copy link
Member

bmbroom commented Jun 14, 2024

Since the type property is deprecated (see here), should we just delete the offending code?

@jmelott
Copy link
Author

jmelott commented Jun 14, 2024

I didn't check to see if we had any code using the value elsewhere.
As long as we change any code that might be dependent on it, if any, deleting it sounds like a good idea.

@bmbroom
Copy link
Member

bmbroom commented Jun 14, 2024

I could not find any uses. I think it was added just to satisfy the original HTML standard. If there were any uses, I think it would be at least as important to fix them.

I'm inclined to not fix them until after the next point release because of the extra testing that would be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants