Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old minified files in NG-CHM-Artifacts server.app #528

Open
marohrdanz opened this issue May 1, 2024 · 0 comments
Open

Old minified files in NG-CHM-Artifacts server.app #528

marohrdanz opened this issue May 1, 2024 · 0 comments
Assignees
@marohrdanz
Labels
general cleanup code, infrastructure, and/or documentation cleanup GitHub Action For issues with GitHub Actions

Comments

@marohrdanz
Copy link
Contributor

marohrdanz commented May 1, 2024 •
edited
Loading

The NG-CHM-Artifacts directory viewer.build/server.app/javascript, contains files generated from each '<!-- NEW CHUNK -->' section from chm.html.

Currently, the GitHub action workflows that build these artifacts (NG-CHM-Artifacts_release.yml and NG-CHM-Artifacts_push_main.yml) generates these files, and adds them to the viewer.build/server.app/javascript directory.

The result is that none of the old versions of these files are removed from this directory in the NG-CHM-Artifacts repo. These old files make it difficult to know which files are relevant for a given version of the NG-CHM viewer code.

To address this, it is suggested to update the two GitHub actions workflows to remove the old files before adding the new files to the git commit.
@marohrdanz marohrdanz added the general cleanup code, infrastructure, and/or documentation cleanup label May 1, 2024
@marohrdanz marohrdanz added the GitHub Action For issues with GitHub Actions label Jun 20, 2024
marohrdanz added a commit that referenced this issue Jun 21, 2024
@marohrdanz
Remove old js min files in Artifacts actions
58a3717 
This addresses issue #528
@marohrdanz marohrdanz self-assigned this Jun 21, 2024
@marohrdanz marohrdanz mentioned this issue Jun 21, 2024
Merged
marohrdanz added a commit that referenced this issue Jun 21, 2024
@marohrdanz
Remove old js min files in Artifacts actions
f2acc3a 
These files clutter up the directory, and make it difficult to determine
which files are relevant to the current version.

This addresses issue #528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marohrdanz marohrdanz

Labels
general cleanup code, infrastructure, and/or documentation cleanup GitHub Action For issues with GitHub Actions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marohrdanz