Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address GitHub Actions issues #536

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Address GitHub Actions issues #536

merged 2 commits into from
Jun 25, 2024

Conversation

marohrdanz
Copy link
Contributor

This merge request addresses the following issues with GitHub Actions:

@marohrdanz
Update NGCHMSupportFiles action to include knitr
b06dcd4 
Updating this action to install knitr before checking the
NGCHMSupportFiles R package so that the vignette can build.

Addresses issue #534
@marohrdanz
Remove old js min files in Artifacts actions
f2acc3a 
These files clutter up the directory, and make it difficult to determine
which files are relevant to the current version.

This addresses issue #528
@marohrdanz marohrdanz marked this pull request as ready for review June 21, 2024 16:45
@ChrisWakefield
Copy link
Member

I'm curious about the git rm only targeting certain *.js files. Are there other files that should also be removed?

@marohrdanz
Copy link
Contributor Author

For the other files, the file name is the same from commit to commit. For example ShaidyMapGen.jar is just overwritten by the new version. But for these .js file, the file names may be different from commit to commit.

ChrisWakefield
ChrisWakefield approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@ChrisWakefield ChrisWakefield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at.

bmbroom
bmbroom approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@bmbroom bmbroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in NGCHM meeting.

@marohrdanz marohrdanz merged commit e8ff4b0 into main Jun 25, 2024
@marohrdanz marohrdanz deleted the actions-fix branch June 25, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisWakefield ChrisWakefield ChrisWakefield approved these changes

@bmbroom bmbroom bmbroom approved these changes

@jmelott jmelott Awaiting requested review from jmelott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marohrdanz @ChrisWakefield @bmbroom