Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label/matrix menu closes immediately in Safari #529

Open
bmbroom opened this issue Jun 13, 2024 · 0 comments
Open

Label/matrix menu closes immediately in Safari #529

bmbroom opened this issue Jun 13, 2024 · 0 comments
Assignees
@bmbroom
Labels
2.23.5 bug ready-for-testing show-stopper

Comments

@bmbroom
Copy link
Member

bmbroom commented Jun 13, 2024

In Safari, trying to open a Matrix/Label using ctrl-Click closes the menu immediately when the mouse is released. The matrix/label menu should not close when the mouse is released.
@bmbroom bmbroom self-assigned this Jun 13, 2024
@bmbroom bmbroom changed the title Label/matrix menu closes immediately in Safaru Label/matrix menu closes immediately in Safari Jun 13, 2024
bmbroom added a commit that referenced this issue Jun 13, 2024
@bmbroom
Prevent Matrix/Label menu closing immediately in Safari. See issue #529.
151878b 
Safari sends a control-click event when other browsers don't.  The extra
event causes the just opened matrix/label menu to close.

This fix: don't close a matrix/label menu if the control key is pressed.
@marohrdanz marohrdanz mentioned this issue Jun 13, 2024
Merged
bmbroom added a commit that referenced this issue Jun 13, 2024
@bmbroom
Merge pull request #530 from MD-Anderson-Bioinformatics/fix-safari-la…
273b1e2 
…bel-menu

Prevent Matrix/Label menu closing immediately in Safari. See issue #529.
ChrisWakefield added a commit that referenced this issue Jun 19, 2024
@ChrisWakefield
Replicate commit 151878b 'Prevent Matrix/Label menu closing immediate…
68212b0 
…ly in Safari. See issue #529.'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmbroom bmbroom

Labels
2.23.5 bug ready-for-testing show-stopper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmbroom