Prevent Matrix/Label menu closing immediately in Safari. See issue #529. #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari sends a control-click event when other browsers don't. The extra event causes the just opened matrix/label menu to close. This fix: don't close a matrix/label menu if the control key is pressed.
jmelott
approved these changes
Jun 13, 2024
|
This seems like a reasonable solution to the bug. It won't break anything else, right? Tagging the issue here so it's linked to this pull request: #529 (linking doesn't work in the title, I think) |
marohrdanz
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari sends a control-click event when other browsers don't. The extra event causes the just opened matrix/label menu to close.
This fix: don't close a matrix/label menu if the control key is pressed.
This fixes a major (show-stopper) bug for Safari users, so I would like it released asap.
P.S. We also need to bump the version number.