Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rarely, expanding a right panel results in a panel that is only partially expanded #535

Open
bmbroom opened this issue Jun 20, 2024 · 3 comments

Comments

@bmbroom
Copy link
Member

bmbroom commented Jun 20, 2024

I have only been able to reproduce this bug using an old saved NG-CHM, specifically the Deprez3000 NG-CHM. Tests on more recent NG-CHMs show the expected behavior.

To reproduce:

  • Open a two-panel Deprez3000 NG-CHM
  • Add a panel below the left panel
  • Expand the right panel

This correctly results in the other panels becoming invisible, but the right panel only expands part way.

I did not see any issues with expanding the other panels.

Closing and then recreating the bottom left panel causes the right panel to behave as expected.

A possibility I have not investigated yet is that this problem occurs only in maps generated using R.

@jmelott
Copy link

jmelott commented Jun 20, 2024

Which browser(s)?

@bmbroom
Copy link
Member Author

bmbroom commented Jun 21, 2024

All I've tried: Chrome, Firefox, and Safari all on Mac.

@jmelott
Copy link

jmelott commented Jun 25, 2024

I'm not seeing the issue on Windows in Chrome or Firefox.
To test the R theory, can you upload all the map data for the map to the builder and see if the issue still happens with the new version of the Deprez 3000 map recreated by the GUI Builder.
If it doesn't then you could do a file compare of both maps to see what's different.

Tests I ran on Windows:
I just tried opening the Deprez 3000 map on Chrome and Firefox on my Windows PC using the Viewer downloaded from loading a map from the current TCGA compendium and clicking the download viewer.
From Viewer: Software Version: 2.24.4; Linkouts Version: 2023-11-21; Map Version: 2.1.0

I also tried it with both those browsers using the older 2.24.1 browser currently served by the test setup on udev 8, http://qcprludev08.mdanderson.edu:8082/NG-CHM/chm.html.
From Viewer: Software Version: 2.24.1; Linkouts Version: 2024-04-02; Map Version: 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants