update PathSimAnalysis install command #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
orbeckst
commented
Sep 12, 2024
orbeckst
commented
- close update PathSimAnalysis installation instructions? #117
- update install from PyPi package to conda-forge package installation
- close #117 - update install from PyPi package to conda-forge package installation
orbeckst
added
mdakit
lilyminium
reviewed
Sep 20, 2024
| @@ -20,7 +20,7 @@ documentation_home: https://mdanalysis.org/PathSimAnalysis | |||
| documentation_type: API | |||
|
|
|||
| install: | |||
| - pip install pathsimanalysis | |||
| - mamba install -c conda-forge pathsimanalysis | |||
There was a problem hiding this comment.
(non-blocking) are we happy to just assume that people will have mamba installed? Or is conda safer?
Otherwise LGTM!
There was a problem hiding this comment.
We use this line ourselves for the workflow so I think this is fine, apart from the fact that it seems a good idea to promote mamba in the eco system.
lilyminium
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.