Fix zarrtraj metadata test dependencies #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAlibay
commented
Oct 13, 2024
| @@ -90,7 +90,7 @@ run_tests: | |||
| ## The default below _might_ be sufficient or you might not even need MDAnalysisTests: | |||
| ## make sure that it is appropriate for how you run tests. | |||
| test_dependencies: | |||
| - mamba env update --file https://raw.githubusercontent.com/Becksteinlab/zarrtraj/main/devtools/conda-envs/test_env.yaml --name test | |||
There was a problem hiding this comment.
@orbeckst since you were the approving reviewer on this, just an FYI - this type of hack will break the registry. It effectively overwrite the base mamba environment so you end up with a conda environment without the base mdakit dependencies.
There was a problem hiding this comment.
ok, thanks, good to know — can you add a note to https://mdakits.mdanalysis.org/reviewersguide.html please ?
There was a problem hiding this comment.
I added a draft entry, please review/edit #212 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.