Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact information for Team page #402

Open
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

jennaswa
Copy link
Contributor

@jennaswa jennaswa commented Sep 2, 2024

Per the discussion in #397, the main purpose of this PR is to:

  • List [email protected] as a general contact email, and
  • Link github profiles to listed team members

In addition, this would provide a good opportunity to update team members in preparation for our first upcoming R&R review, as decided in the Aug 20 business meeting. Namely:

Thanks!

@jennaswa jennaswa requested a review from a team September 2, 2024 10:01
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jennaswa !

I will opt out of including myself in community engagement, but will opt in for project organization.

Re: the build failure, I suspect the autogeneration from yaml might not like the links so much. @lilyminium would be best suited to weigh in on this.

_data/team/roles/project_organization.yml Outdated Show resolved Hide resolved
@lilyminium
Copy link
Member

lilyminium commented Sep 3, 2024

Re: github failure -- yup, I hadn't included Markdown support in the teams pages. I've opened #403 to include this so that should fix it. However, the caveat is that the initial YAML still has to be valid, so all the team member links should be encapsulated in quotes to tell YAML it's a string and not a list. (i.e. "[Jenna Swarthout Goddard](https://github.com/jennaswa)" instead of just plain [Jenna Swarthout Goddard](https://github.com/jennaswa))

_data/team/roles/code_of_conduct.yml Outdated Show resolved Hide resolved
_data/team/roles/community_engagement.yml Outdated Show resolved Hide resolved
_data/team/roles/continuous_integration.yml Outdated Show resolved Hide resolved
_data/team/roles/core_library_maintenance.yml Outdated Show resolved Hide resolved
_data/team/roles/core_library_maintenance.yml Outdated Show resolved Hide resolved
_data/team/roles/outreach.yml Outdated Show resolved Hide resolved
_data/team/roles/project_organization.yml Outdated Show resolved Hide resolved
_data/team/roles/releases_and_deployment.yaml Outdated Show resolved Hide resolved
_data/team/roles/relicensing_coordinator.yml Outdated Show resolved Hide resolved
_data/team/roles/social_media.yml Outdated Show resolved Hide resolved
@lilyminium
Copy link
Member

Added non-blocking comments for quotes. Otherwise LGTM -- thanks for this @jennaswa!

jennaswa and others added 14 commits September 3, 2024 16:43
Copy link
Contributor

@yuxuanzhuang yuxuanzhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed response! I’ve added myself to the teams now.

jennaswa and others added 2 commits December 6, 2024 16:28
- add @RMeli as he's been VERY good about engaging the community
- add myself because I happened to have been contributing more than I thought I would
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated myself.

I also added @RMeli to Community Engagement given his fantastic work in the area but please remove yourself again, Rocco, if that wasn't appropriate.

I am suggesting to add the external mda-encore maintainers to the list, too. @yuxuanzhuang , given that you put yourself down there, could add the suggestion if you think that this is appropriate?

_data/team/roles/community_engagement.yml Show resolved Hide resolved
@@ -7,5 +7,5 @@ tasks:
- Managing the switch to a new license
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave Relicensing Team up for now, at least until we're fully LGPLv2.1+. Eventually we may be able to retire it to history :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retirement will be very well deserved!!!

@orbeckst
Copy link
Member

@lilyminium and @IAlibay you commented but did not approve or asked for changes. Does this mean that you'd be ok with it getting merged as is?

@orbeckst
Copy link
Member

@MDAnalysis/coredevs please review and sign off or ask for changes. Should be a quick thing. Thanks.

_data/team/roles/community_engagement.yml Show resolved Hide resolved
_data/team/roles/non_core_library_maintenance.yml Outdated Show resolved Hide resolved
@@ -7,5 +7,5 @@ tasks:
- Managing the switch to a new license
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retirement will be very well deserved!!!

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it should have been a "request changes".

@orbeckst
Copy link
Member

@RMeli I incorporated your change request.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants