-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert test matrix back to manual #111
Merged
Merged
Changes from 7 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
1e50018
check tests fail
lilyminium 51d4010
update job name
lilyminium 0d44293
reset name back to main-tests
lilyminium 8fb7da0
rm dev
lilyminium d744ba6
change python matrix to manual
lilyminium 102549c
is codecov the problem here?
lilyminium a62d745
dont fail ci for codecov
lilyminium c9de494
remove all dynamic python versions
lilyminium 16324a5
add codecov token?
lilyminium d449d2d
escape braces
lilyminium bfa4b66
ignore codecov failure?
lilyminium 5186c18
upgrade act and allow codecov failure again
lilyminium 007e0a1
add more comment to CI
lilyminium 57050d2
try changing the name of the package
lilyminium 956b25d
Revert "try changing the name of the package"
lilyminium 66a4245
assert False
lilyminium 6b36c22
tmp list directory
lilyminium b860ccf
downgrade act?
lilyminium 2601768
rm assert False
lilyminium 6ffb6c5
pass secret to act
lilyminium efea53e
add actions workaround for secret
lilyminium 9c7a1dd
try oidc?
lilyminium ceec4a3
give up and try editing file to ignore upload failure
lilyminium 51bdcff
Revert "rm assert False"
lilyminium 537f817
Revert "Revert "rm assert False""
lilyminium 0abac8a
Fix CI to fail and run appropriately (#116)
lilyminium fcb4c12
try v4
lilyminium 3dd02ed
bump act action?
lilyminium 2ecd7b0
upgrade versions
lilyminium c2109f4
why isnt this running?
lilyminium 38b8320
reorder os?
lilyminium ca96eaf
upgrade act all the way
lilyminium ba6795f
its called act-latest now?
lilyminium e879faf
oops wrong place
lilyminium c871ad8
add p=false
lilyminium e1d47d5
downgrade codecov back to v4, act back to 0.2.40, see how that goes
lilyminium a685a34
Revert "upgrade versions"
lilyminium File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,6 @@ jobs: | |
runs-on: ubuntu-latest | ||
outputs: | ||
stable-python-version: {{ "${{ steps.get-compatible-python.outputs.stable-python }}" }} | ||
python-matrix: {{ "${{ steps.get-compatible-python.outputs.python-versions }}" }} | ||
lilyminium marked this conversation as resolved.
Show resolved
Hide resolved
lilyminium marked this conversation as resolved.
Show resolved
Hide resolved
|
||
steps: | ||
- uses: actions/setup-python@v4 | ||
with: | ||
|
@@ -46,8 +45,19 @@ jobs: | |
fail-fast: false | ||
matrix: | ||
os: [macOS-latest, ubuntu-latest, windows-latest] | ||
python-version: {% raw %}${{ fromJSON(needs.environment-config.outputs.python-matrix) }}{% endraw %} | ||
python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
lilyminium marked this conversation as resolved.
Show resolved
Hide resolved
|
||
mdanalysis-version: ["latest", "develop"] | ||
exclude: | ||
# Entries here exclude particular combinations of the matrix | ||
# Edit or remove as particular combinations come into or out of date | ||
|
||
# Below we exclude runs with "develop" MDAnalysis and Python 3.9 | ||
- mdanalysis-version: "develop" | ||
lilyminium marked this conversation as resolved.
Show resolved
Hide resolved
|
||
python-version: "3.9" | ||
# Below we exclude runs with the latest release and Python 3.12 | ||
- mdanalysis-version: "latest" | ||
python-version: "3.12" | ||
|
||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
@@ -120,6 +130,10 @@ jobs: | |
if: github.repository == '{{ cookiecutter.github_host_account }}/{{ cookiecutter.repo_name }}' && github.event_name != 'schedule' | ||
uses: codecov/codecov-action@v3 | ||
with: | ||
# codecov can be flaky and result in spurious failures | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tbd - api token entry The main failure here is a lack of API token, not having it often cause failures even when not on forks. How do we best ensure that folks do this? |
||
# the below option will not fail the CI if codecov fails | ||
# change to true to fail the CI if codecov fails | ||
fail_ci_if_error: false | ||
file: coverage.xml | ||
name: codecov-{{ '${{ matrix.os }}' }}-py{{ '${{ matrix.python-version }}' }} | ||
verbose: True | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I had to do with the broken kits was bump up the conda-incubator/setup-miniconda version.
I found a lot of times that v2 would fail with osx-arm64 for some reason or another.