Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ModuleNotFound Error Fix #115

Merged
merged 9 commits into from
May 28, 2024
+9 −5
Merged

[WIP] ModuleNotFound Error Fix #115

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
625c38f
reponame vs packagename fix
ljwoods2 May 24, 2024
3eca258
added test and tweaked version determination
ljwoods2 May 25, 2024
095032e
linting
ljwoods2 May 25, 2024
f6ba774
linting
ljwoods2 May 25, 2024
94dae28
linting
ljwoods2 May 25, 2024
ca6b6f5
debugging github actions- is pip installing into correct env within t…
ljwoods2 May 25, 2024
a68f84a
remove redundant tests
ljwoods2 May 25, 2024
ce02240
Merge branch 'main' into main
lilyminium May 27, 2024
f6f752b
Authors + Changelog + Removed unused import
ljwoods2 May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions {{cookiecutter.repo_name}}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ requires = [
build-backend = "setuptools.build_meta"

[project]
name = "{{cookiecutter.repo_name}}"
name = "{{cookiecutter.package_name}}"
Copy link
Member

@lilyminium lilyminium May 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm -- the docs reckon this name should be what you want the package to be called on PyPI, and allow things like hyphens here. Should this remain just the package name? @orbeckst any opinions here -- what did you have in mind for mdgeomkit?

Edit: sorry I see you reverted this later!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if my input is still needed but for completeness: I just tried a different name for the project_name (the PyPi install name, the one that can have hyphens) from the Python package/module "import" name package_name to see if anything would break... and it did:

project_name [ProjectName]: mdgeomkit
repo_name [mdgeomkit]: mdgeomkit
package_name [mdgeomkit]: mdgeom

description = "{{cookiecutter.description}}"
license = {{ "{" }}file = "LICENSE" {{ "}" }}
authors = [
Expand Down Expand Up @@ -43,12 +43,12 @@ doc = [
# documentation = "https://{{cookiecutter.repo_name}}.readthedocs.io"

[tool.setuptools]
py-modules = []
packages = ["{{cookiecutter.package_name}}"]

[tool.pytest.ini_options]
minversion = "6.0"
testpaths = [
"{{cookiecutter.repo_name}}/tests",
"{{cookiecutter.package_name}}/tests",
lilyminium marked this conversation as resolved.
Show resolved Hide resolved
]

[tool.black]
Expand Down