-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lowercase names #117
Fix lowercase names #117
Conversation
This also looks good on the help screen:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 85.58% 85.56% -0.03%
==========================================
Files 8 8
Lines 569 568 -1
Branches 119 119
==========================================
- Hits 487 486 -1
Misses 67 67
Partials 15 15 ☔ View full report in Codecov by Sentry. |
Cool, should we add in the help page that lowercase module names are also allowed? Basically adding something to the file docstring in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful!
Fix lowercase names (#117)
Fix lowercase names (MDAnalysis#117)
The currently hardcoded lowercasing of the subparser name breaks very fast and workaround are ugly. One way around that would be adding aliases to the subparsers.