Don't fail on codecov upload error #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4575 +/- ##
===========================================
- Coverage 93.66% 93.64% -0.03%
===========================================
Files 168 180 +12
Lines 21248 22327 +1079
Branches 3917 3917
===========================================
+ Hits 19902 20908 +1006
- Misses 888 961 +73
Partials 458 458 ☔ View full report in Codecov by Sentry. |
|
Do we need an issue reminding us to eventually turn it on again? |
Yeah that's probably a good idea - sorry I'm afk, could you open it @RMeli? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp patch for #4574
This will make it so that jobs don't fail if there's an upload issue (i.e. what currently happens with PRs from forks)
HOWEVER
It also means that codecov might not report properlly if things fail. I.e. for reviewers, be aware that codecov suddenly saying there's no coverage could just be that nothing got uploaded.
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4575.org.readthedocs.build/en/4575/