Modernise build a bit and switch to versioningit #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAlibay
changed the title
IAlibay
commented
Oct 27, 2023
| description = "Minimal Cython wrapper of the TNG trajectory library" | ||
| readme = "README.rst" | ||
| authors = [{name = "Max Linke, Richard J Gowers, Hugo MacDermott-Opeskin", email = "[email protected]"}] | ||
| maintainers = [{name = "MDAnalysis Core Developers", email = "[email protected]"}] |
There was a problem hiding this comment.
I'm assuming this is the case now?
There was a problem hiding this comment.
The TNG format is probably dead now, we could probably deprecate this package altogether? But yes
There was a problem hiding this comment.
I'd be keen to maintain fewer things that are dependencies (even if optional) on the core library - that being said I'm not meant to be the lead maintainer on this, so I can't make those decisions.
In the short term, getting this merged & a release out would be great, it's one of the optional deps that blocks the core library going to 3.12 fully.
richardjgowers
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix stuff, I've not yanked out everything in setup.py just in case - but we could be more aggresive at a later point.
Once this is fixed a py3.12 release will be needed.