Improve Option formatting #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/option-value-formatting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 81.23% 81.38% +0.14%
==========================================
Files 23 23
Lines 1407 1418 +11
==========================================
+ Hits 1143 1154 +11
Misses 264 264 ☔ View full report in Codecov by Sentry. |
- Change SeparatorFormatter to take the key and value as arguments and return an array of strings. This is what I think most would expect and works better with `Process` which seems to be picky about an option's key and value being separate elements in the array. - Rename BodyFormatter to KeyFormatter which is a more clear name - Rename SeparatorFormatter.space to separate which is a more clear name
feature/option-value-formatting
roanutil
changed the title
r-jarvis
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processwhich seems to be picky about an option's key and value being separate elements in the array.