Skip to content

Commit

Permalink
People Page: change photo alt and id #60
Browse files Browse the repository at this point in the history
Changes the photos on the People Page to include a more descriptive alt tag: Roger Mark to photo of Roger Mark. Also changes photo id to be more descriptive: Roger_Mark to photo_of_Roger_Mark. Fixes part of #60.

Changes photo alt tag

Returns old style

Fixes People Page header ordering #60.

Fixes the h2 tag of the lab members name to an h3 tag to stay consistent with the rest of the header tags. Fixes part of #60.
  • Loading branch information
Lucas-Mc committed Sep 9, 2020
1 parent 29fb777 commit dd6cbae
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
6 changes: 3 additions & 3 deletions main.py
Original file line number Diff line number Diff line change
Expand Up @@ -399,11 +399,11 @@ def people():
"""
data = _data()

path = "sitedata"
fn = "people.yml"
path = 'sitedata'
fn = 'people.yml'

with open(os.path.join(path, fn), 'r') as f:
data["people"] = yaml.safe_load(f)
data['people'] = yaml.safe_load(f)

return render_template('people.html', **data)

Expand Down
11 changes: 8 additions & 3 deletions templates/people.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,19 @@ <h1 class="site-section-title">People</h1>
<h2 class="site-section border-bottom" id="researchers">Current members</h2>

{% for person in people.current_members %}
<div id="{{ person.name | replace(' ','_') }}">
<<<<<<< HEAD
<div id="#{{ person.name | replace(' ','_') }}">
<h2 class="site-section-meta">{{ person.name }}</h2>
=======
<div id="{{ person.name | replace(' ','_') }}">
<h3 class="site-section-meta">{{ person.name }}</h3>
>>>>>>> a5b61e0... Fixes People Page header ordering #60.
<div class="row">
<div class="col-md-2">
{% if person.image %}
<img class="img-fluid" width="120" src="{{ url_for('static', filename='images/' + person.image )}}" alt="{{ person.name }}">
<img class="img-fluid" width="120" src="{{ url_for('static', filename='images/' + person.image )}}" alt="Photo of {{ person.name }}">
{% else %}
<img class="img-fluid" width="120" src="{{ url_for('static', filename='images/missing.jpg' )}}" alt="{{ person.name }}">
<img class="img-fluid" width="120" src="{{ url_for('static', filename='images/missing.jpg' )}}" alt="Photo of {{ person.name }}">
{% endif %}
</div>
<div class="col-md-9">
Expand Down

0 comments on commit dd6cbae

Please sign in to comment.