Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes some links open in new tabs #60 #66

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Makes some links open in new tabs #60 #66

merged 2 commits into from
Sep 8, 2020

Conversation

Lucas-Mc
Copy link
Collaborator

@Lucas-Mc Lucas-Mc commented Sep 8, 2020

Changes some links to open in a new tab. Specifically, the links in the footer and the continue reading links were changed. Direct links to other pages in the navbar are unchanged. Fixes part of #60.

Changes some links to open in a new tab. Specifically, the links in the footer and the continue reading links were changed. Direct links to other pages in the navbar are unchanged. Fixes part of #60.
@tompollard
Copy link
Member

I'd avoid new window pop-ups altogether, but if we want to use them we should try to be consistent with how they are used. One simple distinction is for new windows to be used only for external links.

In this pull request, some of the internal pages open in new windows (e.g. "Continue reading), while others don't, which is confusing.

It would be good to draw attention to links that open in new windows, either with some "opens in new window" text or an accessibility icon. On PhysioNet we use this:

a[target='_blank']::after {
content: '\29C9';
padding: 0em 0.15em;
}

Screen Shot 2020-09-08 at 15 46 32

@tompollard
Copy link
Member

Looking at the W3C recommendations on links opening in new windows at: https://www.w3.org/TR/WCAG20-TECHS/G201.html, they suggest that:

Opening new windows automatically when a link is activated can be disorienting for people who have difficulty perceiving visual content, and for some people with cognitive disabilities, if they are not warned in advance.

This page highlights some issues with popping up pages in new windows: https://accessibility.oit.ncsu.edu/it-accessibility-at-nc-state/developers/accessibility-handbook/mouse-and-keyboard-events/links/links-and-new-windows/

@tompollard tompollard merged commit 29fb777 into dev Sep 8, 2020
@tompollard tompollard deleted the change_links branch September 8, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants