Allow submitting author status to be transferred to a co-author. Ref #2128

[tompollard]

As discussed in #2128, currently the submitting author of a project cannot be changed. There are times when it would be helpful to allow submitting authors to transfer this status to co-authors. e.g. when:

• A co-author would like to take responsibility for editing content or uploading files.
• A project requires updating and the original submitting author is no longer available.

This change adds a 'transfer project' button to the author page of the project submission system.

[bemoody]

Not tested but sounds like a great idea.

If the project is published then only the original submitting author can create a new version. (I have thought that it would be nice to allow any author to do that, but that can be another PR.)

However, we don't want to allow the original submitting author to create two new versions of the same project - does this still prevent that?

[tompollard]

we don't want to allow the original submitting author to create two new versions of the same project - does this still prevent that?

Good question! I tested this fairly thoroughly and, as far as I can see, it is not possible to create multiple new versions of a project. e.g. if the submitting author creates a new version and transfers the new version to a co-author, it is not possible to create a second new version.

I think the logic that prevents multiple new versions is defined here:

physionet-build/physionet-django/project/views.py

Lines 317 to 340 in cece757

	def new_project_version(request, project_slug):
	"""
	Publish a new version of a project
	"""
	if settings.SYSTEM_MAINTENANCE_NO_UPLOAD:
	raise ServiceUnavailable()
	user = request.user
	n_submitting = Author.objects.filter(user=user, is_submitting=True,
	content_type=ContentType.objects.get_for_model(ActiveProject)).count()
	if n_submitting >= ActiveProject.MAX_SUBMITTING_PROJECTS:
	return render(request, 'project/project_limit_reached.html',
	{'max_projects':ActiveProject.MAX_SUBMITTING_PROJECTS})
	previous_projects = PublishedProject.objects.filter(
	slug=project_slug).order_by('-version_order')
	latest_project = previous_projects.first()
	# Only submitting author can make new. Also can only have one new version
	# of this project out at a time.
	if not latest_project.can_publish_new(user):
	return redirect('project_home')

... and here:

physionet-build/physionet-django/project/modelcomponents/publishedproject.py

Lines 254 to 261 in cece757

	def can_publish_new(self, user):
	"""
	Whether the user can publish a new version of this project
	"""
	if user == self.submitting_user() and not self.core_project.active_new_version():
	return True
	return False

[bemoody]

Sounds good, thanks for checking.

Could you add a test case in project/test_views.py? It looks like the demo "MIMIC-III Clinical Database" (slug = T108xFtYkRAxiRiuOLEJ) has rgmark as submitting author and aewj as a coauthor, so we should be test reassigning it.

[tompollard]

@bemoody Test case added!

[bemoody]

+        self.assertTrue(self.submitting_author.user.email, self.AUTHOR_EMAIL)
+        self.assertTrue(self.coauthor.user.email, self.COAUTHOR_EMAIL)

You mean assertEqual here.

[tompollard]

You mean assertEqual here.

Good catch, now fixed.