Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing matchDetails in MA3 feeds #584

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

probberechts
Copy link
Member

No description provided.

@probberechts probberechts added the bug Something isn't working label Sep 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 81.25% and project coverage change: -0.06% ⚠️

Comparison is base (72aca85) 82.75% compared to head (d5aa385) 82.69%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   82.75%   82.69%   -0.06%     
==========================================
  Files          47       47              
  Lines        3374     3375       +1     
  Branches      563      565       +2     
==========================================
- Hits         2792     2791       -1     
  Misses        491      491              
- Partials       91       93       +2     
Files Changed Coverage Δ
socceraction/data/opta/parsers/ma3_json.py 93.22% <76.92%> (-1.10%) ⬇️
socceraction/data/opta/schema.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probberechts probberechts merged commit 49881bd into master Sep 10, 2023
22 checks passed
@probberechts probberechts deleted the fix/ma3-missing-game-duration branch September 10, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants