Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StatsBomb] Fix fidelity of shot y-coordinates #628

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

probberechts
Copy link
Member

The y-coordinate of a shot in the goal frame is always detailed to a tenth of a yard.

The y-coordinate of a shot in the goal frame is always detailed to a tenth of a yard.
@probberechts probberechts added the bug Something isn't working label Dec 29, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb54b17) 82.87% compared to head (14ead11) 82.94%.
Report is 3 commits behind head on release/v1.5.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.5     #628      +/-   ##
================================================
+ Coverage         82.87%   82.94%   +0.06%     
================================================
  Files                47       47              
  Lines              3433     3447      +14     
  Branches            566      569       +3     
================================================
+ Hits               2845     2859      +14     
  Misses              493      493              
  Partials             95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probberechts probberechts merged commit 966b412 into release/v1.5 Dec 29, 2023
20 checks passed
@probberechts probberechts deleted the fix/statsbomb-shot-fidelity branch December 29, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants