Use stable sort for ordering events/actions #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probberechts
changed the title
When two events or actions have identical timestamps, we should keep the order in the original data. However, since the default sorting algorithm used by Panda's sort_values-method is not stable, the order of such events or actions could get switched.
probberechts
force-pushed
the
fix/stable-sort
branch
from
bd08f3e
to
ce09cb1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/v1.5 #637 +/- ##
=============================================
Coverage 82.93% 82.93%
=============================================
Files 47 47
Lines 3445 3445
Branches 568 568
=============================================
Hits 2857 2857
Misses 493 493
Partials 95 95 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two events or actions have identical timestamps, we should keep the order in the original data. However, since the default sorting algorithm used by Panda's sort_values-method is not stable, the order of such events or actions could get switched.