Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docstrings #29

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

DeleMike
Copy link

  • Added Docstrings to all functions in app.py, models.py and some functions in test_pytest.py

Fixes #2

@DeleMike
Copy link
Author

@dtemir please review

@winstxnhdw
Copy link
Member

winstxnhdw commented Jun 22, 2023

Hi @DeleMike, I went ahead and addressed this partially in #30.

@DeleMike
Copy link
Author

Oh okay. So what happens now?

@winstxnhdw
Copy link
Member

winstxnhdw commented Jun 23, 2023

I think we should pick a standard for writing docstrings because our styles are very different and honestly, the PEP rules on docstrings are vague at best.

@DeleMike
Copy link
Author

Okay then, I agree that we should have a standard style. We can agree on that after tomorrow's standup. We can get everyone's thoughts. However, is there a standard way?

@dtemir
Copy link
Member

dtemir commented Jun 23, 2023

Hey @DeleMike @winstxnhdw ! Thank you for the discussion. I had the chance to review Winston's PR #30 first and get it merged. Are there any docstrings outstanding?

@DeleMike
Copy link
Author

DeleMike commented Jun 23, 2023

@dtemir
Yes, @winstxnhdw said all files except app.py follow the Pylint and Pyright ruleset. I assume this file has some outstanding work. Am I correct @winstxnhdw ?

@winstxnhdw
Copy link
Member

Yeap. app.py is untouched.

@DeleMike DeleMike marked this pull request as draft June 24, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docstrings to include more detail
3 participants