HW#11_MengtingYU #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Application for Identifying the Opportunites of Transit-oriented Development (TOD) in Long Island
rossbernet
reviewed
Apr 12, 2019
| @@ -55,6 +125,11 @@ are hard to use and think about. Global variables are a strategy for | |||
| coping with that difficulty by breaking data out of the asynchronous | |||
| context. | |||
|
|
|||
| - The most difficult part may be an interactive chart that shows the | |||
There was a problem hiding this comment.
Next week @moradology will be going over chart.js.
You can get a head start looking at the documentation:
https://chartjs.org/samples/latest/
Double check which one you might want to use, but I think if you can pull this off well it's going to make this a strong project.
rossbernet
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
My only concern is whether there will be enough meaningful user interactivity.
It looks like much of the valuable part of this application (the TOD scores) will be done in pre-processing. Is that true?
If you can pull off the Chart JS, that has the potential to be quite strong if it's interactive. Do you have a fuller sense of what you'd want to show with that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed Final Project Proposal v1.0: An Application for Identifying the Opportunites of Transit-oriented Development (TOD) in Long Island