HW 2 Li Zhuang #21
Open
HW 2 Li Zhuang #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbernet
reviewed
Feb 3, 2019
| popupAnchor: [0, -20]}); | ||
|
|
||
|
|
||
| let healthArray = [["LNG","LAT","OBJECTID","NAME","ORGANIZATION","ZIP","PHONE","WEBSITE","DENTAL_PHONE","FULL_ADDRESS"]]; |
There was a problem hiding this comment.
It'd be good to not have to type out each of these keys manually.
Take a look how at this: Object.keys(healthCenters[0]) Does all the work for you!
rossbernet
reviewed
Feb 3, 2019
rossbernet
reviewed
Feb 3, 2019
| } | ||
| else { | ||
| L.marker([healthArray[j][1], healthArray[j][0]], {icon: iconDen}).addTo(map) | ||
| .bindPopup(`${healthArray[j].slice(3)}`); |
There was a problem hiding this comment.
Did you mean to show just the name? Or everything also after the name?
It's a little busy. Slice is probably not the best method to use.
But if you change it to: .bindPopup(${healthArray[j][3]});
That just grabs the name
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.