HW2 Jiazuo Zhang #29
Open
HW2 Jiazuo Zhang #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbernet
reviewed
Feb 2, 2019
| @@ -19,7 +19,7 @@ | |||
| <!--Your code starts here--> | |||
| <script> | |||
| var map = L.map('map', { | |||
| center: [39.9522, -75.1639], | |||
| center: [39.9522, -72.0000], | |||
There was a problem hiding this comment.
This change is not helpful and... a bit confusing.
It's good to play around with parameters to see what they do.
But when I first opened up your map, it was in the middle of the ocean, and it looked like the map was not loading properly.
It'd be helpful if the map is centered on the appropriate zoom to level to the data you are tying to show.
rossbernet
reviewed
Feb 2, 2019
| csvHC.push(header) | ||
| for (var i = 0; i < healthCenters.length; i = i+1) { | ||
| csvHC.push(Object.values(healthCenters[i])) | ||
| }; |
There was a problem hiding this comment.
This does indeed produce the intended output.
But it does not actually log it to the console.
Can you modify the jsonToCsv function such that it executes these commands when then function is called below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.