Mengting YU_HW#9 #1
Conversation
|
Where are the links to the maps? |
|
Sorry, I'm not quite clear about the requirement of "Publish them through github pages" and "Include the links to the live examples in your pull request."
I downloaded the examples from Mapbox gl js and modified them in local, then created a Github page for this repo. The link I added to pull request is the Github page's link. Shall we publish the maps through Mapbox studio as what we did in the lab?
Thanks,
Mengting
…________________________________
From: Ross Bernet <[email protected]>
Sent: Thursday, March 28, 2019 11:48 AM
To: MUSA611-CPLN692-spring2019/cpln692-week9
Cc: Yu, Mengting; Author
Subject: Re: [MUSA611-CPLN692-spring2019/cpln692-week9] Mengting YU_HW#9 (#1)
Where are the links to the maps?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AsqCeVXa7_HYb7lEHXcTupXjvlaQoD4Oks5vbOQ9gaJpZM4cQUwp>.
|
|
Take a look at my example PR: When I click on the link in the PR it takes me directly to a map. There will be a trick to providing access to two maps. There are a couple ways to do it. It may require two different links. Let me know if that is too vague. But you should be able to get at least one map using the github pages publish method. |
|
And sorry the expectations for delivery were not more clear. You are quite close. And I just realized you have the html files, but I did not see them at first because it wasn't called: Take a look at: https://astoriayu.github.io/cpln692-week9/customstyle.html GH pages looks for an index.html file. Otherwise, you can pass it the html location at the end of your GH pages link and it will display that page. And there is no need to use mapbox studio I would suggest you add some HTML to describe what the maps are. But that is not strictly speaking necessary. |
|
I added alert descriptions for the maps, here are the links to the pages: |
|
Very nice. |
Published GitHub page: https://astoriayu.github.io/cpln692-week9/