Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let az and za arrays have an arbitrary number of axes #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnsmorgan
Copy link
Collaborator

This is a modest change to mwa_pb. At present, the zenith angle and azimuth arrays must have two dimensions (i.e. assuming that you want to make a primary beam image). Often you just want the primary beam for a list of locations. The following generalise the code so that an arbitrary number of dimensions can be used. I've located one function that will fail with this change (plotVisResponse) and made sure that it fails with a proper error.

I've tested this code for some basic use cases without any issues.

Before merging, can someone please double-check my first change to primary_beam.py (the swapaxes on) I think it's equivalent to the two cases it replaces, but it would be good for someone to double-check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant