-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: core and cli installer #118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid passing dirs to every function, we add a global DIRS variable to store the dirs.
`set_var` may interfere with other tests, so we should set it in the same test that uses it.
The set_var may interfere with other tests, so we should cache the default config to avoid this.
The maa core failed to exit, I have no idea why.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
===========================================
+ Coverage 25.96% 40.79% +14.83%
===========================================
Files 21 24 +3
Lines 1606 1733 +127
===========================================
+ Hits 417 707 +290
+ Misses 1189 1026 -163 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
core-installer
feature to disable core installation.Refactors:
find_lib/resource
into methods ofDirs
.DIRS
variable to avoid pass it everywhere.BREAKING CHANGES:
self
feature withcli_installer
.maa update
reject updatingMaaCore
installed at non-standard locations.MaaCore
.channel
incli.toml
.