ci: use tag pattern to filter out pre-releases #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, we have been using the `compare_base` output from the `parse_version.sh` script to determine the range of commits to be included in the changelog. This not works well, because the pre-release also splits the commits into multiple groups. For example, if the last stable release is `v0.1.0`, and last beta release is `v0.1.1-beta.1`, then the changelog from head will include all commits from `v0.1.0` to head, but they will be split into two groups: `v0.1.0..v0.1.1-beta.1` and `v0.1.1-beta.1..HEAD`. This is not what we want. So instead of using `compare_base`, we use the `tag_pattern` to filter out pre-releases. This will ensure that the changelog compares to the last stable release, and they are grouped into a single group.
If release channel is beta, don't update alpha version info, because alpha version is nightly, once a beta version is installed, alpha version will be considered as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we have been using the
compare_baseoutput from theparse_version.shscript to determine the range of commits to be included in the changelog. This not works well,because the pre-release also splits the commits into multiple groups. For example, if the last stable release is
v0.1.0, and last beta release isv0.1.1-beta.1, then the changelog from head will include all commits fromv0.1.0to head, but they will be split into two groups:v0.1.0..v0.1.1-beta.1andv0.1.1-beta.1..HEAD. This is not what we want.So instead of using
compare_base, we use thetag_patternto filter out pre-releases. This will ensure that the changelog compares to the last stable release, and they are grouped into a single group.