Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: resource update and refactor maa core binding #126

Merged
merged 38 commits into from
Dec 12, 2023
Merged

Conversation

wangl-cc
Copy link
Member

@wangl-cc wangl-cc commented Dec 4, 2023

Features:

  • Introduce resource update functionality by fetch MaaResource repo. There are two backend of git: command git and library libgit2.

Refactors:

  • Reorganize configs.
  • Restructure mod run.
  • Move some types into maa-sys.
  • Replace the use of transport provided by rustls with native_tls.

BREAKING CHANGES:

  • Resource-related configurations have been moved to a separate section, 'resource'.

Build features:

  • cli_installer: Provides maa self update and can be disabled when compiled by a package manager.
  • core_installer: Provides maa install/update and may be disabled when compiled as an AppImage.
  • git2: Provides the resource update backend libgit2.
  • vendored-openssl: Compiles and statically links OpenSSL for git2 (all platforms) and reqwest (on Linux) if OpenSSL is not available in the system. This feature is not enabled by default.

@wangl-cc wangl-cc marked this pull request as draft December 4, 2023 12:16
@wangl-cc wangl-cc changed the title refactor!: maa core binding refactor!: maa core binding and resource update Dec 4, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 301 lines in your changes are missing coverage. Please review.

Comparison is base (e276d77) 38.59% compared to head (a16eb12) 50.77%.

Files Patch % Lines
maa-cli/src/installer/resource.rs 0.00% 89 Missing ⚠️
maa-cli/src/run/mod.rs 7.93% 58 Missing ⚠️
maa-cli/src/config/asst.rs 70.18% 48 Missing ⚠️
maa-cli/src/run/copilot.rs 74.50% 26 Missing ⚠️
maa-cli/src/run/playcover.rs 21.87% 25 Missing ⚠️
maa-cli/src/main.rs 0.00% 13 Missing ⚠️
maa-sys/src/error.rs 0.00% 12 Missing ⚠️
maa-cli/src/config/cli/resource.rs 66.66% 5 Missing ⚠️
maa-cli/src/config/task/client_type.rs 86.84% 5 Missing ⚠️
maa-cli/src/run/fight.rs 0.00% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #126       +/-   ##
===========================================
+ Coverage   38.59%   50.77%   +12.18%     
===========================================
  Files          25       32        +7     
  Lines        1832     1934      +102     
===========================================
+ Hits          707      982      +275     
+ Misses       1125      952      -173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangl-cc wangl-cc changed the title refactor!: maa core binding and resource update feat: resource update Dec 10, 2023
BREAKING CHANGE: `base_resource_dirs` can not be set by user now
@wangl-cc wangl-cc changed the title feat: resource update feat!: resource update Dec 11, 2023
@wangl-cc wangl-cc changed the title feat!: resource update feat!: resource update and refactor maa core binding Dec 11, 2023
@wangl-cc wangl-cc marked this pull request as ready for review December 11, 2023 19:20
@wangl-cc wangl-cc merged commit 24c7a89 into main Dec 12, 2023
23 checks passed
@wangl-cc wangl-cc deleted the refactor/run branch December 12, 2023 12:49
@wangl-cc wangl-cc mentioned this pull request Dec 12, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant