-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: resource update and refactor maa core binding #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangl-cc
changed the title
refactor!: maa core binding
refactor!: maa core binding and resource update
Dec 4, 2023
wangl-cc
force-pushed
the
refactor/run
branch
from
December 8, 2023 20:18
62a6475
to
52c67c5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
===========================================
+ Coverage 38.59% 50.77% +12.18%
===========================================
Files 25 32 +7
Lines 1832 1934 +102
===========================================
+ Hits 707 982 +275
+ Misses 1125 952 -173 ☔ View full report in Codecov by Sentry. |
wangl-cc
changed the title
refactor!: maa core binding and resource update
feat: resource update
Dec 10, 2023
BREAKING CHANGE: `base_resource_dirs` can not be set by user now
wangl-cc
changed the title
feat!: resource update
feat!: resource update and refactor maa core binding
Dec 11, 2023
In some cases, if two tests are run in parallel, they will both try to create the user resource directory. This will cause a panic.
This was referenced Jan 12, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
MaaResource
repo. There are two backend of git: commandgit
and librarylibgit2
.Refactors:
run
.maa-sys
.rustls
withnative_tls
.BREAKING CHANGES:
Build features:
cli_installer
: Providesmaa self update
and can be disabled when compiled by a package manager.core_installer
: Providesmaa install/update
and may be disabled when compiled as an AppImage.git2
: Provides the resource update backendlibgit2
.vendored-openssl
: Compiles and statically links OpenSSL forgit2
(all platforms) andreqwest
(on Linux) if OpenSSL is not available in the system. This feature is not enabled by default.