fix: use self-replace to update maa-cli self #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
On windows, the maa-cli binary is locked by the system when it is running. This makes it impossible to update the binary directly. To solve this problem, we can use the self-replace crate to update the binary. Besides, constcat crate is added to create some platform-specific file names. The extract function is slightly modified to accept a closure that accepts a Cow<Path> instead of a &Path.
wangl-cc
force-pushed
the
fix/self-replace
branch
from
49d1ed6 to
0093d96
Compare
wangl-cc
force-pushed
the
fix/self-replace
branch
from
fb2acbf to
3206c85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 66.22% 66.22%
=======================================
Files 42 42
Lines 3624 3624
=======================================
Hits 2400 2400
Misses 1224 1224 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, the maa-cli binary is locked by the system when it is running. This makes it impossible to update the binary directly. To solve this problem, we can use the self-replace crate to update the binary.
Besides, constcat crate is added to create some platform-specific file names. The extract function is slightly modified to accept a closure that accepts a Cow instead of a &Path.