Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to exit on windows #79

Merged
merged 3 commits into from
Oct 14, 2023
Merged

fix: failed to exit on windows #79

merged 3 commits into from
Oct 14, 2023

Conversation

wangl-cc
Copy link
Member

@wangl-cc wangl-cc commented Oct 14, 2023

Try run with MaaCore failed to exit in CI.
See: https://github.com/MaaAssistantArknights/maa-cli/actions/runs/6516174359/job/17699423949

It seems caused by stop_bool.store(true, std::sync::atomic::Ordering::Relaxed),
see https://github.com/MaaAssistantArknights/maa-cli/actions/runs/6516380388/job/17699850335?pr=79#step:9:41.

Solution: We disable signal handling on windows as a temporary fix. But we can't remove signal_hook from dependencies on windows now, because of lifetime of variable in conditional block.

@wangl-cc
Copy link
Member Author

Maybe we can disable signal handling on windows.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2023

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (778d641) 21.27% compared to head (dde582d) 21.59%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   21.27%   21.59%   +0.31%     
==========================================
  Files          20       20              
  Lines        1438     1468      +30     
==========================================
+ Hits          306      317      +11     
- Misses       1132     1151      +19     
Files Coverage Δ
maa-cli/src/installer/maa_core.rs 4.08% <ø> (+0.08%) ⬆️
maa-cli/src/config/asst.rs 79.16% <75.00%> (+33.33%) ⬆️
maa-cli/src/installer/extract.rs 0.00% <0.00%> (ø)
maa-cli/src/main.rs 4.41% <0.00%> (+4.41%) ⬆️
maa-cli/src/run/mod.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangl-cc wangl-cc merged commit c5f7277 into main Oct 14, 2023
@wangl-cc wangl-cc deleted the fix/not-stop branch October 14, 2023 18:36
@horror-proton
Copy link
Member

horror-proton commented Oct 15, 2023

https://github.com/horror-proton/maa-cli/actions/runs/6517462151/attempts/1
Unable to reproduce, that's strange

@wangl-cc
Copy link
Member Author

This occurred unexpectedly and happened after the merge of this pr. I'll need to conduct further investigation to understand the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants