Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCM support for text-to-speech #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PCM support for text-to-speech #183

wants to merge 1 commit into from

Conversation

vilcsak
Copy link

@vilcsak vilcsak commented Mar 19, 2024

What

I'm not sure if it's a recent change but the API supports pcm for text-to-speech and it isn't supported by this library. A simple change to allow pcm as a format.

Why

Bring up to spec with the API

Affected Areas

Text-to-speech

Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@SunburstEnzo SunburstEnzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a comment on whether it's worth also adding wav support while we're here.

@@ -548,7 +548,7 @@ public struct AudioSpeechQuery: Codable, Equatable {
**Response:**

```swift
/// Audio data for one of the following formats :`mp3`, `opus`, `aac`, `flac`
/// Audio data for one of the following formats :`mp3`, `opus`, `aac`, `flac`, `pcm`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly the documentation also mentions wav, so I'm wondering if we should add that as well to this PR or a separate PR.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants