-
Notifications
You must be signed in to change notification settings - Fork 231
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Converted mutable matrices to matrices in instances of
sub()
At some point M2 no longer allowed for mutable matrices to be used in `sub()`. Instances of this was fixed by converting the mutable matrices to a matrix.
- Loading branch information
Branden Stone
authored
Jun 27, 2023
1 parent
5572c8a
commit d55ea7c
Showing
1 changed file
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ newPackage( | |
Date => "May 10, 2013", | ||
Authors => { | ||
{Name => "Brett Barwick", Email => "[email protected]", HomePage => "http://faculty.uscupstate.edu/bbarwick/"}, | ||
{Name => "Branden Stone", Email => "bstone@adelphi.edu", HomePage => "http://math.adelphi.edu/~bstone/"} | ||
{Name => "Branden Stone", Email => "[email protected].edu", HomePage => "http://bstone.github.io/"} | ||
}, | ||
Headline => "the Quillen-Suslin algorithm for bases of projective modules", | ||
Keywords => {"Commutative Algebra"}, | ||
|
@@ -1457,7 +1457,7 @@ monicPolySubs(RingElement,List) := opts -> (f,varList) -> ( | |
print "The element had degree zero in the last variable."; | ||
degZeroSub = mutableMatrix vars R; | ||
degZeroSub = columnSwap(degZeroSub,last usedVarPosition,lastVarPosition); | ||
f = sub(f,degZeroSub); -- Interchange variables so that last varList is involved in f. Now f has positive degree in last varList. | ||
f = sub(f,matrix degZeroSub); -- Interchange variables so that last varList is involved in f. Now f has positive degree in last varList. | ||
); | ||
|
||
-- Now we enter the general algorithm. | ||
|
@@ -1495,7 +1495,7 @@ monicPolySubs(RingElement,List) := opts -> (f,varList) -> ( | |
if degZeroSub =!= null then ( | ||
print("degZeroSub: "|toString(degZeroSub)); | ||
tempSub = columnSwap(tempSub,last usedVarPosition,lastVarPosition); | ||
tempInvSub = sub(tempInvSub,degZeroSub); | ||
tempInvSub = sub(matrix tempInvSub,matrix degZeroSub); | ||
); | ||
|
||
return (matrix tempSub,matrix tempInvSub); | ||
|