Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualTally improvements, minor expressions fixes #2918

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

pzinn
Copy link
Contributor

@pzinn pzinn commented Aug 23, 2023

  • added Number*VirtualTally, VirtualTally == VirtualTally. took this opportunity to optimize VirtualTally ? VirtualTally.
  • various minor fixes to expressions, e.g., this used to happen due to an annoying inheritance conflict:
i29 : debug Core

i30 : expression 3*ONE

o30 = 3

o30 : Expression of class Holder

i31 : 3*expression 2*ONE

o31 = 3*2*1

o31 : Expression of class Product

now o31 = 3*2

@mikestillman
Copy link
Member

@pzinn Could you merge in development into your open pull requests? This should hopefully fix the errors occuring in github actions.

@mikestillman mikestillman merged commit 609eec6 into Macaulay2:development Aug 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants